-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: type #722
Merged
Merged
feat: type #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Expose
type
property inEventEmitter
events.💡 Motivation and Context
Added a new property to
KeyboardEventData
-type
. This property reflectskeyboardType
set onTextInput
.I decided to include more information about the keyboard (we already have a full control over animation properties, but I thought it could be useful to extend the library functionality and include some other properties, such as
type
/appearance
/capitalized
and other).As of now there is no much sense in these properties, but I'm thinking about new API
KeyboardController.retain()
/KeyboardController.hold()
- and in this case it's super useful to know these properties, to re-create the sameTextInput
and set focus to this newly created input.However it's only plans, but having this information in the API can be useful, so I decided to add it now.
📢 Changelog
Docs
JS
type
fromKeyboardEvents
events;iOS
UIKeyboardType
extension;KeyboardEventEmitterPayload.swift
file to cleanupKeyboardMovementObserver
;Android
EditText.keyboardType
extension;🤔 How Has This Been Tested?
Tested manually on:
📸 Screenshots (if appropriate):
📝 Checklist